[Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

Zhenyu Wang zhenyuw at linux.intel.com
Tue Oct 18 06:46:14 UTC 2016


On 2016.10.18 09:47:56 +0300, Joonas Lahtinen wrote:
> On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote:
> > @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt *gvt, unsigned int reg)
> >  
> >  	reg &= ~GENMASK(11, 0);
> >  	for (i = 0; i < I915_NUM_ENGINES; i++) {
> > -		if (gvt->dev_priv->engine[i].mmio_base == reg)
> > +		if (gvt->dev_priv->engine[i]->mmio_base == reg)
> >  			return i;
> >  	}
> 
> This loop is bad now that engine[i] might be NULL. Use for_each_engine
> instead.
> 

yes, we're fixing this with newly merged code and testing for VM,
should be fixed in next pull request.

Thanks

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20161018/a86c306c/attachment.sig>


More information about the Intel-gfx mailing list