[Intel-gfx] [PATCH v3 03/15] drm: Add support for optional per-plane rotation property

[Daniel Vetter]

On Tue, Sep 27, 2016 at 01:22:48PM +0300, Ville Syrjälä wrote:
> On Tue, Sep 27, 2016 at 12:54:46PM +0300, Joonas Lahtinen wrote:
> > On ma, 2016-09-26 at 19:30 +0300, ville.syrjala at linux.intel.com wrote:
> > > diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
> > > 
> > > index 85172a977bf3..e52aece30900 100644
> > > --- a/drivers/gpu/drm/drm_blend.c
> > > +++ b/drivers/gpu/drm/drm_blend.c
> > 
> > Now that I'm thinking, *_zpos_* fits to drm_blend.c nicely, but not
> > sure if rotation is related to blending so much. Maybe it should be
> > like a new file drm_transform.c (or drm_plane.c to be overly generic),
> > not sure.
> 
> The next guy who moves it gets to rebase all of my ~500 branches! Or
> alternatively gets to make git smarter so it'll detect the pointless
> shuffling automagically.

My idea behind drm_blend is to cover _everything_ between the raw
framebuffer data and the final crtc picture. So scaling, rotation,
blending and anything like that.

I should probably have called it compositing, but oh well that fail is now
done.
-Daniel

> 
> > 
> > Anyway,
> > 
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > 
> > Regards, Joonas
> > -- 
> > Joonas Lahtinen
> > Open Source Technology Center
> > Intel Corporation
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch