[Intel-gfx] [PATCH v2 08/15] drm/msm/mdp5: Set rotation property initial value to BIT(DRM_ROTATE_0) insted of 0

[Ville Syrjälä]

On Fri, Oct 21, 2016 at 06:26:54PM +0200, Daniel Vetter wrote:
> On Mon, Sep 26, 2016 at 07:30:53PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > 0 isn't a valid rotation property value, so let's set the initial value
> > of the property to BIT(DRM_ROTATE_0) instead.
> > 
> > In the same vein, we must always have at leat one angle as part of
> > set of supported rotation bits, so let's include DRM_ROTATE_0
> > in there.
> > 
> > v2: Drop the BIT()
> > 
> > Cc: Rob Clark <robdclark at gmail.com>
> > Cc: Jilai Wang <jilaiw at codeaurora.org>
> > Cc: Archit Taneja <architt at codeaurora.org>
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> This one here had a conflict, so didn't apply. Not sure if still needed.

I think Rob picked it up already.

> -Daniel
> 
> > ---
> >  drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > index ba8f43278a44..b0ecf5357bfd 100644
> > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > @@ -78,12 +78,12 @@ static void mdp5_plane_install_rotation_property(struct drm_device *dev,
> >  	if (!dev->mode_config.rotation_property)
> >  		dev->mode_config.rotation_property =
> >  			drm_mode_create_rotation_property(dev,
> > -			DRM_REFLECT_X | DRM_REFLECT_Y);
> > +			DRM_ROTATE_0 | DRM_REFLECT_X | DRM_REFLECT_Y);
> >  
> >  	if (dev->mode_config.rotation_property)
> >  		drm_object_attach_property(&plane->base,
> >  			dev->mode_config.rotation_property,
> > -			0);
> > +			DRM_ROTATE_0);
> >  }
> >  
> >  /* helper to install properties which are common to planes and crtcs */
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Ville Syrjälä
Intel OTC