[Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

[Tvrtko Ursulin]

On 25/10/2016 09:18, Chris Wilson wrote:
> On Tue, Oct 25, 2016 at 09:06:26AM +0100, Tvrtko Ursulin wrote:
>>
>> On 24/10/2016 17:55, Praveen Paneri wrote:
>>> This adds Y-tiling check in igt_create_fb_with_bo_size as
>>> now we should also be able to create Y-tiled FBs.
>>>
>>> Signed-off-by: Praveen Paneri <praveen.paneri at intel.com>
>>> ---
>>> lib/igt_fb.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>>> index 47472f4..bf1d372 100644
>>> --- a/lib/igt_fb.c
>>> +++ b/lib/igt_fb.c
>>> @@ -608,7 +608,8 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
>>> 		  __func__, fb->gem_handle, fb->stride);
>>>
>>> 	if (tiling != LOCAL_DRM_FORMAT_MOD_NONE &&
>>> -	    tiling != LOCAL_I915_FORMAT_MOD_X_TILED) {
>>> +	    tiling != LOCAL_I915_FORMAT_MOD_X_TILED &&
>>> +	    tiling != LOCAL_I915_FORMAT_MOD_Y_TILED) {
>>> 		do_or_die(__kms_addfb(fd, fb->gem_handle, width, height,
>>> 				      fb->stride, format, tiling,
>>> 				      LOCAL_DRM_MODE_FB_MODIFIERS, &fb_id));
>>>
>>
>> This works now? Ie. doesn't hit "No Y Tiling for legacy addfb" error
>> in the driver?
>
> That legacy check still exists :(, but __kms_addfb() lies and calls addfb2.

And this change makes the code not call __kms_addfb but the else branch 
which does not set the modifiers at all AFAICS.

REgards,

Tvrtko