[Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

[Daniel Vetter]

On Wed, Oct 26, 2016 at 09:09:26AM +0100, Tvrtko Ursulin wrote:
> 
> On 26/10/2016 07:32, Daniel Vetter wrote:
> > On Tue, Oct 25, 2016 at 03:02:33PM +0000, Paneri, Praveen wrote:
> > > > So when you say that all Y tiling tests fail without this kernel hack, which tests you are referring to?
> > > If I revert this IGT patch and do not make below kernel change, kms_draw_crc (ytiled cases, last patch in this series) fail with following error.
> > > 
> > > Test assertion failure function igt_assert_crc_equal, file hardware/intel/intel-gpu-tools/lib/igt_debugfs.c:266:
> > > Failed assertion: a->crc[i] == b->crc[i]
> > > error: 0x68c96b8b != 0x948e53b
> > > 
> > > I think, I shall debug it further and try to fix it without making this change.
> > 
> > Can't we just set the fb modifiers when creating the drm_fb in the igt
> > helpers?
> 
> Thats already there, if I understand what you mean. But it only does the
> modifer and does not set the object tiling. So I suspect this test might be
> depending on object tiling being set as well? In which case we  may be
> missing the capability to create the object separately from the fb creation,
> because otherwise it is too late to try to change the object tiling.

Yeah I guess then my question is: Why can't we use that? This patch sounds
like duct-tape instead of proper bugfix ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch