[Intel-gfx] [PATCH] Another flavour of for_each_engine_masked()

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Sep 1 14:36:28 UTC 2016


On to, 2016-09-01 at 15:17 +0100, Dave Gordon wrote:
> This macro was recently updated to skip testing for non-existent or
> uninteresting engines by using ffs() to directly find the next engine of
> interest. However, it required the introduction of a caller-provided
> temporary variable, which some people regard as inelegant. So, this
> patch provides another variant, which still uses the fast-skip mechanism
> but without requiring the temporary, for the cost of a slight increase
> in code size (~20 bytes per callsite).

I did the same kind of modification, it got Nacked.

I'd myself vote for loosing the temporary for 20 bytes too.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list