[Intel-gfx] [PATCH 0/8] SKL/KBL watermark fixes

Paulo Zanoni paulo.r.zanoni at intel.com
Wed Sep 7 00:52:11 UTC 2016


Hi

This series is the result of me comparing the code against BSpec. It
doesn't solve any particular problem I was seeing, but there's enough
changes that this code could potentially change the watermarks values
for most machines. Maybe this will fix somebody's underrun? Even if it
doesn't, we should still have a code that matches the specification
unless there's a big justification.

I still didn't finish reviewing everything and there's at least one
workaround that we seem to be missing, but let's try to get these
patches merged first.

Thanks,
Paulo

Cc: Lyude <cpaul at redhat.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Cc: Mahesh Kumar <mahesh1.kumar at intel.com>

Paulo Zanoni (8):
  drm/i915: SAGV is not SKL-only, so rename a few things
  drm/i915: introduce intel_has_sagv()
  drm/i915/kbl: KBL also needs to run the SAGV code
  drm/i915/gen9: fix the WaWmMemoryReadLatency implementation
  drm/i915/gen9: minimum scanlines for Y tile is not always 4
  drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations
  drm/i915/gen9: fix the watermark res_blocks value
  drm/i915/gen9: implement missing case for SKL watermarks calculation

 drivers/gpu/drm/i915/i915_drv.h      |  10 +-
 drivers/gpu/drm/i915/intel_display.c |   9 +-
 drivers/gpu/drm/i915/intel_drv.h     |   6 +-
 drivers/gpu/drm/i915/intel_pm.c      | 177 ++++++++++++++++++++---------------
 4 files changed, 111 insertions(+), 91 deletions(-)

-- 
2.7.4



More information about the Intel-gfx mailing list