[Intel-gfx] [PATCH v4 10/25] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data

[Kamble, Sagar A]

On 9/7/2016 8:26 PM, Dave Gordon wrote:
> On 07/09/16 14:52, kbuild test robot wrote:
>> Hi Tom,
>>
>> [auto build test ERROR on drm-intel/for-linux-next]
>> [also build test ERROR on next-20160907]
>> [cannot apply to v4.8-rc5]
>> [if your patch is applied to the wrong git tree, please drop us a 
>> note to help improve the system]
>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or 
>> --base=auto for convenience) to record what (public, well-known) 
>> commit your patch series was built on]
>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>
>> url: 
>> https://github.com/0day-ci/linux/commits/Sagar-Arun-Kamble/Add-support-for-GuC-based-SLPC/20160907-201335
>> base:   git://anongit.freedesktop.org/drm-intel for-linux-next
>> config: i386-defconfig (attached as .config)
>> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=i386
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/gpu/drm/i915/intel_slpc.c: In function 
>> 'slpc_get_slice_count':
>>>> drivers/gpu/drm/i915/intel_slpc.c:50:37: error: 'const struct 
>>>> intel_device_info' has no member named 'slice_total'
>>       slice_count = INTEL_INFO(dev_priv)->slice_total;
>>                                         ^~
>>
>> vim +50 drivers/gpu/drm/i915/intel_slpc.c
>>
>>     44
>>     45    static unsigned int slpc_get_slice_count(struct 
>> drm_i915_private *dev_priv)
>>     46    {
>>     47        unsigned int slice_count = 1;
>>     48
>>     49        if (IS_SKYLAKE(dev_priv))
>>   > 50            slice_count = INTEL_INFO(dev_priv)->slice_total;
>>     51
>>     52        return slice_count;
>>     53    }
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source 
>> Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
>>
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> Is this the right fix?
Yes. I forgot to rebase. Thanks.
Will be sending new series as v4 as earlier one did not go as 
series(went as individual patches - i had done "git format-patch -k ")
>
> diff --git a/drivers/gpu/drm/i915/intel_slpc.c 
> b/drivers/gpu/drm/i915/intel_slpc.c
> index 1a3a515..77a316e 100644
> --- a/drivers/gpu/drm/i915/intel_slpc.c
> +++ b/drivers/gpu/drm/i915/intel_slpc.c
> @@ -207,7 +207,7 @@ static unsigned int slpc_get_slice_count(struct 
> drm_i915_private *dev_priv)
>         unsigned int slice_count = 1;
>
>         if (IS_SKYLAKE(dev_priv))
> -               slice_count = INTEL_INFO(dev_priv)->slice_total;
> +               slice_count = 
> hweight8(INTEL_INFO(dev_priv)->sseu.slice_mask);
>
>         return slice_count;
>  }
>
> .Dave.