[Intel-gfx] [PATCH v4 07/26] drm/i915/slpc: Use intel_slpc_* functions if supported

[Kamble, Sagar A]

Thanks for the review.


On 9/9/2016 10:50 PM, Chris Wilson wrote:
> On Fri, Sep 09, 2016 at 06:21:26PM +0530, Sagar Arun Kamble wrote:
>> @@ -6720,31 +6743,38 @@ void intel_enable_gt_powersave(struct drm_i915_private *dev_priv)
>> +	if (intel_slpc_enabled()) {
>> +	} else {
>>   
>> -	WARN_ON(dev_priv->rps.max_freq < dev_priv->rps.min_freq);
>> -	WARN_ON(dev_priv->rps.idle_freq > dev_priv->rps.max_freq);
>> +		WARN_ON(dev_priv->rps.max_freq < dev_priv->rps.min_freq);
>> +		WARN_ON(dev_priv->rps.idle_freq > dev_priv->rps.max_freq);
>>   
>> -	WARN_ON(dev_priv->rps.efficient_freq < dev_priv->rps.min_freq);
>> -	WARN_ON(dev_priv->rps.efficient_freq > dev_priv->rps.max_freq);
>> +		WARN_ON(dev_priv->rps.efficient_freq < dev_priv->rps.min_freq);
>> +		WARN_ON(dev_priv->rps.efficient_freq > dev_priv->rps.max_freq);
> You seem to be chickening out of some sanity checks on values we present
> to the user.
> -Chris

Will restore these. idle_freq not applicable to SLPC hence will remove 
check for it with SLPC.

>