[Intel-gfx] [PATCH v4 17/26] drm/i915/slpc: Add enable/disable debugfs for slpc

Kamble, Sagar A sagar.a.kamble at intel.com
Thu Sep 15 10:42:48 UTC 2016



On 9/9/2016 10:24 PM, Chris Wilson wrote:
> On Fri, Sep 09, 2016 at 06:21:36PM +0530, Sagar Arun Kamble wrote:
>> +static ssize_t slpc_dcc_write(struct file *file, const char __user *ubuf,
>> +			      size_t len, loff_t *offp)
>> +{
>> +	struct seq_file *m = file->private_data;
>> +	int ret = 0;
>> +
>> +	ret = slpc_param_write(m, ubuf, len, SLPC_PARAM_TASK_ENABLE_DCC,
>> +			       SLPC_PARAM_TASK_DISABLE_DCC);
>> +	if (ret)
>> +		return (size_t) ret;
> What value is (ssize_t)(size_t)-1 as seen by userspace? Is it negative?
Will fix this. casting is not needed.
> -Chris
>



More information about the Intel-gfx mailing list