[Intel-gfx] [PATCH 4/6] drm/i915: use NULL for NULL pointers

Pandiyan, Dhinakaran dhinakaran.pandiyan at intel.com
Thu Sep 15 17:09:13 UTC 2016


Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>

On Thu, 2016-09-15 at 16:28 +0300, Jani Nikula wrote:
> Fix sparse warning:
> 
> drivers/gpu/drm/i915/i915_cmd_parser.c:987:72: warning: Using plain
> integer as NULL pointer
> 
> Fixes: 52a42cec4b70 ("drm/i915/cmdparser: Accelerate copies from WC memory")
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> index 3c72b3b103e7..70980f82a15b 100644
> --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> @@ -984,7 +984,7 @@ static u32 *copy_batch(struct drm_i915_gem_object *dst_obj,
>  
>  	src = ERR_PTR(-ENODEV);
>  	if (src_needs_clflush &&
> -	    i915_memcpy_from_wc((void *)(uintptr_t)batch_start_offset, 0, 0)) {
> +	    i915_memcpy_from_wc((void *)(uintptr_t)batch_start_offset, NULL, 0)) {
>  		src = i915_gem_object_pin_map(src_obj, I915_MAP_WC);
>  		if (!IS_ERR(src)) {
>  			i915_memcpy_from_wc(dst,



More information about the Intel-gfx mailing list