[Intel-gfx] [PATCH i-g-t] lib/igt_core: Print stacktrace in initialization/fixture blocks.

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 20 08:35:39 UTC 2016


On Tue, Sep 20, 2016 at 11:20:38AM +0300, Marius Vlad wrote:
> Likely candidate for this behaviour is the igt_fixture block. Seen in the CI by
> running tests/kms_psr_sink_crc which is causing segfaults in the fixture block.
> 
> While at it fix some minor printing bugs.
> 
> Signed-off-by: Marius Vlad <marius.c.vlad at intel.com>
> CC: Chris Wilson <chris at chris-wilson.co.uk>
> ---
> @@ -1740,7 +1740,7 @@ static void fatal_sig_handler(int sig)
>  			igt_assert_eq(write(STDERR_FILENO, ".\n", 2), 2);
>  		}
>  
> -		if (in_subtest && crash_signal(sig)) {
> +		if (crash_signal(sig)) {
>  			/* Linux standard to return exit code as 128 + signal */
>  			if (!failed_one)
>  				igt_exitcode = 128 + sig;
> @@ -1749,7 +1749,8 @@ static void fatal_sig_handler(int sig)
>  #ifdef HAVE_LIBUNWIND
>  			print_backtrace_sig_safe();
>  #endif
> -			exit_subtest("CRASH");
> +			if (in_subtest)
> +				exit_subtest("CRASH");

Makes sense, I think - as much as I know this part of igt at least!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list