[Intel-gfx] [PATCH] drm/i915: don't report compression when fbc disabled

Paulo Zanoni paulo.r.zanoni at intel.com
Mon Sep 26 18:20:29 UTC 2016


Em Qui, 2016-09-22 às 14:19 +0530, vathsala nagaraju escreveu:
> when i915_fbc_status is read while fbc is disabled,
> it reports compressing to be true, which is confusing.
> report compressing only when fbc is enabled.
> 
> Signed-off-by: vathsala nagaraju <vathsala.nagaraju at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index cfcc72e..fb10cfc 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1658,7 +1658,8 @@ static int i915_fbc_status(struct seq_file *m,
> void *unused)
>  		seq_printf(m, "FBC disabled: %s\n",
>  			   dev_priv->fbc.no_fbc_reason);
>  
> -	if (INTEL_GEN(dev_priv) >= 7)
> +	if (intel_fbc_is_active(dev_priv) &&
> +	    INTEL_GEN(dev_priv) >= 7)

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

I'll push this patch soon. Thanks for the patch!

>  		seq_printf(m, "Compressing: %s\n",
>  			   yesno(I915_READ(FBC_STATUS2) &
>  				 FBC_COMPRESSION_MASK));


More information about the Intel-gfx mailing list