[Intel-gfx] [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client
Chris Wilson
chris at chris-wilson.co.uk
Tue Sep 27 12:19:15 UTC 2016
On Tue, Sep 27, 2016 at 01:07:13PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Several things we can clean up in this function:
>
> * Request and file passed in cannot be NULL. There is
> a single caller which makes it impossible so change
> that condition to a GEM_BUG_ON instead of a WARN
> with a return code.
And move it next to the single caller since this is a specialised
function that is tied to userspace batches.
And the spinlock here is superfluous.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list