[Intel-gfx] [PATCH 02/18] drm/i915: introduce drm_i915_gem_object page_size members

[Joonas Lahtinen]

Commit message to explain why.

On ti, 2017-04-04 at 23:11 +0100, Matthew Auld wrote:
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>

<SNIP>

> 
> @@ -2441,6 +2441,8 @@ static int ____i915_gem_object_get_pages(struct drm_i915_gem_object *obj)
>  	struct sg_table *pages;
>  
>  	GEM_BUG_ON(i915_gem_object_has_pinned_pages(obj));
> +	GEM_BUG_ON(!is_valid_gtt_page_size(obj->page_size));
> +	GEM_BUG_ON(!is_valid_gtt_page_size(obj->gtt_page_size));

GEM_BUG_ON(!HAS_PAGE_SIZE(obj->i915, obj->page_size));
GEM_BUG_ON(!HAS_PAGE_SIZE(obj->i915, obj->gtt_page_size));

Patches should be split functionally, not for the sake of splitting.
Tt's rather hard to complete review when the appearing code is pretty
much no-op, so for next you could squash them a bit. For now, as a leap
of faith;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation