[Intel-gfx] [PATCH v2 5/5] drm/i915: Add more OA configs for BDW, CHV, SKL + BXT

[Robert Bragg]

On Mon, Mar 27, 2017 at 7:16 PM, Matthew Auld <
matthew.william.auld at gmail.com> wrote:

> On 03/23, Robert Bragg wrote:
> > These are auto generated from an XML description of metric sets,
> > currently maintained in gputop, ref:
> >
> >  https://github.com/rib/gputop
> >  > gputop-data/oa-*.xml
> >  > scripts/i915-perf-kernelgen.py
> >
> >  $ make -C gputop-data -f Makefile.xml
> >
> > Signed-off-by: Robert Bragg <robert at sixbynine.org>
> > ---
>
> <SNIP>
>
> >  int i915_oa_select_metric_set_bdw(struct drm_i915_private *dev_priv)
> >  {
> > -     dev_priv->perf.oa.mux_regs = NULL;
> > -     dev_priv->perf.oa.mux_regs_len = 0;
> > -     dev_priv->perf.oa.b_counter_regs = NULL;
> > -     dev_priv->perf.oa.b_counter_regs_len = 0;
> > -     dev_priv->perf.oa.flex_regs = NULL;
> > -     dev_priv->perf.oa.flex_regs_len = 0;
> > +     dev_priv->perf.oa.mux_regs = NULL;
> > +     dev_priv->perf.oa.mux_regs_len = 0;
> > +     dev_priv->perf.oa.b_counter_regs = NULL;
> > +     dev_priv->perf.oa.b_counter_regs_len = 0;
> > +     dev_priv->perf.oa.flex_regs = NULL;
> > +     dev_priv->perf.oa.flex_regs_len = 0;
> What changed? I can't tell from the diff...
>

I don't think anything changed in those lines, it's just that the diff uses
the start of the function for context and then has to delete these to add
the full replacement for the function body which included substantial
changes to add the cases for the additional configs.


>
> Otherwise assuming you re-spin with the DRM_DEBUG changes:
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
>

thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20170405/71d3dabc/attachment.html>