[Intel-gfx] [PATCH 4/5] drm/i915: Split the engine info table in two levels, using class + instance

Oscar Mateo oscar.mateo at intel.com
Thu Apr 6 13:29:39 UTC 2017



On 04/06/2017 01:12 PM, Chris Wilson wrote:
> On Thu, Apr 06, 2017 at 05:55:43AM -0700, Oscar Mateo wrote:
>> There are some properties that logically belong to the engine class, and some
>> that belong to the engine instance. Make it explicit.
>>
>> v2: Commit message (Tvrtko)
>>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_engine_cs.c | 72 +++++++++++++++++++++-------------
>>   1 file changed, 44 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
>> index 2409908..506ec952 100644
>> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
>> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
>> @@ -26,71 +26,83 @@
>>   #include "intel_ringbuffer.h"
>>   #include "intel_lrc.h"
>>   
>> -static const struct engine_info {
>> +struct engine_class_info {
>>   	const char *name;
>>   	unsigned int exec_id;
> Ugh. What??? Each engine will have a unique exec/uabi id.
> -Chris
Ok, I'll move it back to the instance if it matches better the VLC load 
balancing work?


More information about the Intel-gfx mailing list