[Intel-gfx] [PATCH 2/2] drm/i915: Simplify shrinker locking

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 7 11:30:28 UTC 2017


On Fri, Apr 07, 2017 at 01:49:35PM +0300, Joonas Lahtinen wrote:
> By using the same structure for both interruptible and
> uninterruptible locking in shrinker code, combined with the
> information that mm.interruptible is only being written to, the
> code can be greatly simplified.
> 
> Also removing the i915_gem_ prefix from the locking functions so
> that nobody in their wildest dreams considers exporting them.
> 
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

I still feel uneasy that I'm not using mm.uninterruptible in some parts of
modesetting, nevertheless the change is correct, simplies the current
code and means I have to fix gen2 properly if anyone ever notices.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list