[Intel-gfx] [PATCH v3] ACPI / bus: Introduce a list of ids for "always present" devices

Lukas Wunner lukas at wunner.de
Sun Apr 9 10:06:59 UTC 2017


On Sun, Apr 09, 2017 at 11:46:41AM +0200, Hans de Goede wrote:
> On 09-04-17 09:26, Lukas Wunner wrote:
> > On Sat, Apr 08, 2017 at 05:05:11PM +0200, Hans de Goede wrote:
> > > +		pr_debug("Device [%s] is in always present list setting status [%08x]\n",
> > > +			 adev->pnp.bus_id, ACPI_STA_DEFAULT);
> > 
> > In a lot of places in drivers/acpi/, dev_warn(&adev->dev, ...) is used.
> 
> Rafael asked me to use pr_debug here. But I agree that maybe always
> logging something when this trigger might be a good idea, although
> warning is too high a loglevel IMHO. So I would got with dev_info.

Sorry for not being clear, I just meant that existing code seems to
prefer the dev_*() macros to report device-specific stuff, I wasn't
referring to the severity level.

Thanks,

Lukas


More information about the Intel-gfx mailing list