[Intel-gfx] [PATCH v2] drm/i915: Fix use after free in lpe_audio_platdev_destroy()

[Chris Wilson]

On Wed, Apr 12, 2017 at 10:19:01PM +0300, Ville Syrjälä wrote:
> On Wed, Apr 12, 2017 at 01:42:36PM +0200, Takashi Iwai wrote:
> > On Wed, 12 Apr 2017 10:02:51 +0200,
> > Chris Wilson wrote:
> > > v2: Just leak the memory (8 bytes) as freeing it ourselves is not safe,
> > > and we need to coordinate a proper fix in platform_device itself.
> > > 
> > > Fixes: eef57324d926 ("drm/i915: setup bridge for HDMI LPE audio driver")
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> > > Cc: Jerome Anand <jerome.anand at intel.com>
> > > Cc: Jani Nikula <jani.nikula at intel.com>
> > > Cc: Takashi Iwai <tiwai at suse.de>
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > 
> > I'm for v2.
> >   Reviewed-by: Takashi Iwai <tiwai at suse.de>
> 
> I concur
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

v2 is the clear winner, pushed. Leaks for everyone, yay!
 
> Dropping the comment is easy if/when the platdev code gets fixed.

Hopefully sometime before we enable kasan in BAT... Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre