[Intel-gfx] [PATCH] drm/i915/guc: write wopcm related register once during uc init

[Joonas Lahtinen]

On to, 2017-04-06 at 17:18 -0700, Daniele Ceraolo Spurio wrote:
> The wopcm registers are write-once, so any write after the first one
> will just be ignored. The registers survive a GPU reset but not
> always a suspend/resume cycle, so to keep things simple keep the
> writes in the intel_uc_init_hw function instead of moving it earlier
> to make sure we attempt them every time we try to load GuC.
> 
> Cc: Jeff McGee <jeff.mcgee at intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

This is an improvement, so:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

To be exact, shouldn't we read the value and see if it has been written
previously (bit 1). i915 module can be removed and added multiple
times.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation