[Intel-gfx] [PATCH 0/2] GuC logger redesign

[chris at chris-wilson.co.uk]

On Thu, Apr 27, 2017 at 09:22:11AM +0000, Olinski, Krzysztof E wrote:
> On Thu, 2017-04-27 at 10:05 +0100, Chris Wilson wrote:
> > On Thu, Apr 27, 2017 at 10:59:18AM +0200, Krzysztof E. Olinski wrote:
> > > GuC logger implementation simplified and moved to a library
> > > (GuCLAW).
> > > Adds simple buffering utility for logging routine (BUC).
> > 
> > Bigger question, why? What designs goals do you want to achieve?
> > -Chris
> > 
> Currently, there are problems with compilation for Android platform due
> to pthread dependencies. The proposed implementation should work both
> for Linux and Android. I thought that this will be also a good occasion
> to introduce lockless mechanisms to improve efficiency.

I dispute the improved efficiency -- you add an extra copy in reading
the log data ;) If the xfer of the log data is not dominant, something
is very wrong in the framework.

Ok, I missed that pthreads are unworkable on android. If you can kill
the copy, be my guest.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre