[Intel-gfx] [PATCH v3] drm/i915: Sanitize engine context sizes

Chris Wilson chris at chris-wilson.co.uk
Thu Apr 27 10:19:28 UTC 2017


On Thu, Apr 27, 2017 at 12:01:11PM +0300, Joonas Lahtinen wrote:
> @@ -266,11 +239,12 @@ __create_hw_context(struct drm_i915_private *dev_priv,
>  	list_add_tail(&ctx->link, &dev_priv->context_list);
>  	ctx->i915 = dev_priv;
>  
> -	if (dev_priv->hw_context_size) {
> +	if (dev_priv->engine[RCS]->context_size) {

Totally missed this. This is for legacy only. Long term fix is to do
deferred allocation for legacy context objects (i.e. just move this
chunk to intel_ring_context_pin under a if (!ce->state) guard).

Quick and dirty fix is if(!execlists && RCS->context_size).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list