[Intel-gfx] [PATCH 2/2] drm/i915: Eliminate HAS_HW_CONTEXTS

[Ville Syrjälä]

On Thu, Apr 27, 2017 at 04:32:55PM +0100, Chris Wilson wrote:
> On Thu, Apr 27, 2017 at 05:36:55PM +0300, Ville Syrjälä wrote:
> > On Thu, Apr 27, 2017 at 04:41:33PM +0300, Joonas Lahtinen wrote:
> > > According to Chris i915_gem_sanitize was meant to reset ILK too.
> > 
> > In that case drawing the line before g4x might make more sense
> > since it already has a GPU reset that doesn't clobber the display.
> 
> The initial reasoning for the cutoff was anything that used contexts for
> real. We do want to extend it to everything that we can realiably reset.
> One step at a time.

This patch looked more like three steps to me. First step could have
been just removing the flag and adjusting the code to check for gen>=6.

>  
> > > 
> > > CCID register existed already on ILK according to the PRM (Chris
> > > verified the address to match too).
> > 
> > I think it has existed since forever actually. Well, not sure about
> > gen0-1.
> 
> Hmm, didn't realise that (or completely forgot). Logical contexts exist
> for gen2/3 as well. Enabling for g4x+ might be fun.

Not sure it's actually functional there. The docs seem to indicate
that there's some linkage between contexts and run lists.

-- 
Ville Syrjälä
Intel OTC