[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

Mika Kahola mika.kahola at intel.com
Wed Aug 2 13:18:14 UTC 2017


On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote:
> After a bit of digging into this n_words conundrum that I also could
> not understand, I found the issue Mika described.
> 
> kms_plane_multiple et al basically do
> 
> igt_crc_t crc;
> 
> 
> and then they pass &crc to test-internal helper functions, which pass
> the igt_crc_t* pointer to various igt lib functions. The problem is,
> those lib functions take igt_crc_t** so that they can give you the
> correct pointer, kms_plane* wrongly expect them to modify the passed
> object.
> 
> Mika, can you fix this while you're at it?
Right, we can do this without changing the original function call. I'll
throw a patch shortly.

Cheers,
Mika

> 
> 
> 
> --
> Petri Latvala


More information about the Intel-gfx mailing list