[Intel-gfx] [PATCH] drm/i915/cnl: Removing missing DDI_E bits from CNL.

[Rodrigo Vivi]

merged to dinq, thanks for the review.


On Tue, Aug 8, 2017 at 4:36 AM, Imre Deak <imre.deak at intel.com> wrote:
> On Thu, Aug 03, 2017 at 03:51:37PM -0700, Rodrigo Vivi wrote:
>> DDI_E is not supported on CNL-U and CNL-Y
>>
>> When adding the inital support we noticed DDI_E wasn't supported
>> and removed it on v4 and v5 of that patch.
>> However for some reason I missed or put back these 2 chunks.
>>
>> Time to clean it up to avoid later confusion.
>>
>> Fixes: 8bcd3dd41766 ("drm/i915/cnl: Add power wells for CNL")
>> Cc: Clint Taylor <clinton.a.taylor at intel.com>
>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Cc: Imre Deak <imre.deak at intel.com>
>> Cc: Daniel Vetter <daniel.vetter at intel.com>
>> Cc: Jani Nikula <jani.nikula at linux.intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>
> Looks ok and also the correct thing for CNL_H/S, where the port E DDI
> power well is separate from port A and not dependent on power well #2
> (unlike SKL):
>
> Reviewed-by: Imre Deak <imre.deak at intel.com>
>
>> ---
>>  drivers/gpu/drm/i915/intel_runtime_pm.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> index 347484ed6d2c..e77e84a6fd2f 100644
>> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> @@ -1796,7 +1796,6 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
>>       BIT_ULL(POWER_DOMAIN_PORT_DDI_B_LANES) |                \
>>       BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) |                \
>>       BIT_ULL(POWER_DOMAIN_PORT_DDI_D_LANES) |                \
>> -     BIT_ULL(POWER_DOMAIN_PORT_DDI_E_LANES) |                \
>>       BIT_ULL(POWER_DOMAIN_AUX_B) |                       \
>>       BIT_ULL(POWER_DOMAIN_AUX_C) |                   \
>>       BIT_ULL(POWER_DOMAIN_AUX_D) |                   \
>> @@ -1805,7 +1804,6 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
>>       BIT_ULL(POWER_DOMAIN_INIT))
>>  #define CNL_DISPLAY_DDI_A_IO_POWER_DOMAINS (         \
>>       BIT_ULL(POWER_DOMAIN_PORT_DDI_A_IO) |           \
>> -     BIT_ULL(POWER_DOMAIN_PORT_DDI_E_IO) |           \
>>       BIT_ULL(POWER_DOMAIN_INIT))
>>  #define CNL_DISPLAY_DDI_B_IO_POWER_DOMAINS (         \
>>       BIT_ULL(POWER_DOMAIN_PORT_DDI_B_IO) |           \
>> --
>> 2.13.2
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br