[Intel-gfx] [PATCH] drm/i915/cnl: Fix LSPCON support.

Rodrigo Vivi rodrigo.vivi at gmail.com
Wed Aug 16 14:50:04 UTC 2017


merged to dinq. thanks for the reviews.

On Wed, Aug 16, 2017 at 3:47 AM, Sharma, Shashank
<shashank.sharma at intel.com> wrote:
> There is probably one more place where we want this change, but I will try
> to cover that in my 4:2:0 for lspcon patch set.
>
> Meanwhile, please feel free to use:
>
> Reviewed-by: Shashank Sharma <shashank.sharma at intel.com>
>
>
> Regards
> Shashank
>
> On 8/16/2017 8:34 AM, Rodrigo Vivi wrote:
>>
>> When LSPCON support was extended to CNL
>> one part was missed on lspcon_init.
>>
>> So, instead of adding check per platform on lspcon_init
>> let's use HAS_LSPCON that is already there for that
>> purpose.
>>
>> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
>> Cc: Shashank Sharma <shashank.sharma at intel.com>
>> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c
>> b/drivers/gpu/drm/i915/intel_lspcon.c
>> index 5abef482eacf..beb9baaf2f2e 100644
>> --- a/drivers/gpu/drm/i915/intel_lspcon.c
>> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
>> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port
>> *intel_dig_port)
>>         struct drm_device *dev = intel_dig_port->base.base.dev;
>>         struct drm_i915_private *dev_priv = to_i915(dev);
>>   -     if (!IS_GEN9(dev_priv)) {
>> -               DRM_ERROR("LSPCON is supported on GEN9 only\n");
>> +       if (!HAS_LSPCON(dev_priv)) {
>> +               DRM_ERROR("LSPCON is not supported on this platform\n");
>>                 return false;
>>         }
>>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br


More information about the Intel-gfx mailing list