[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Don't use MI_STORE_DWORD_IMM on Sandybridge/vcs (rev2)

[Chris Wilson]

Quoting Patchwork (2017-08-17 16:36:15)
> == Series Details ==
> 
> Series: series starting with [1/7] drm/i915: Don't use MI_STORE_DWORD_IMM on Sandybridge/vcs (rev2)
> URL   : https://patchwork.freedesktop.org/series/28859/
> State : success
> 
> == Summary ==
> 
> Series 28859v2 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/28859/revisions/2/mbox/
> 
> fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:455s
> fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:445s
> fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:556s
> fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:526s
> fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:526s
> fi-byt-n2820     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:512s
> fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:610s
> fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:448s
> fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:423s
> fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:419s
> fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:507s
> fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:477s
> fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:475s
> fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:595s
> fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:604s
> fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:527s
> fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:471s
> fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:466s
> fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:492s
> fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:443s
> fi-skl-x1585l    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:484s
> fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:547s
> fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:408s
> 
> e1b18fbd4daecb1c1cf31ca101f64e29a8933bcf drm-tip: 2017y-08m-17d-14h-58m-23s UTC integration manifest
> 7c0a37b11bd0 drm/i915: Mark the GT as busy before idling the previous request
> 0e4845519fbb drm/i915: Trivial grammar fix s/opt of/opt out of/ in comment
> 6928515da09d drm/i915: Replace execbuf vma ht with an idr
> dca8988c612a drm/i915: Simplify eb_lookup_vmas()
> 84ca392b85e3 drm/i915: Convert execbuf to use struct-of-array packing for critical fields
> a9902e0bff38 drm/i915: Check context status before looking up our obj/vma
> 155bcaa01da6 drm/i915: Don't use MI_STORE_DWORD_IMM on Sandybridge/vcs

Thank you everyone for the review, it's the last bit of execbuf tuning I
have planned for a while, so you can feel relieved about that. (Just
hopefully minor fixes like size_t promotion remain.)

Where do we go with execbuf from here? It is still the most prominent
kernel overhead for many clients (although _pageflip_ is a surprising
contender). There's some work we can do to improve scalability of
reservation_object, but I think we have come to the end of the road for
execbuf2 (the last major interface improvement was 2011). Do we care to
hash out a plan for execbuf3? A few suggestions have focused on the use
of ringbuffers for passing commands between userspace and the kernel,
along with more compact instructions that eliminate a lot of redundancy
between execbuf calls; i.e. we try to keep all the preprocessing in
userspace, with the kernel doing the resource checking around execution.
Ideas?
-Chris