[Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

[Arkadiusz Hiler]

On Mon, Aug 21, 2017 at 08:05:58AM +0000, Dec, Katarzyna wrote:
> I understand we do not want to check registers in IGT tests. What
> about reading interrupt masks from debugfs (i915_frequency_info).

Hey Kasia

It would be pretty much the same thing, but instead of us reading the
PMINTRMASK directly we would ask the kernel to do that on our behalf.

That would just hide register read, not get rid of it.


I think you are missing the point. The idea is that we do not want to
test details of in-kernel implementation, not ban the register reads
completely.

Reading register directly, especially just to make sure that the kernel
set something correctly is a good indicator that we are trying to do
just that - test the internal details.

> Would that be better approach? You guys suggested to get interested in
> kselftests for having such checks, but I am afraid that it could be
> too much job and we have too few hands to work.

How much of an effort would the kselftest be, since it seems that you did some
investigation already?

-- 
Cheers,
Arek