[Intel-gfx] [maintainer-tools PATCH 23/30] qf: SC2053 - Fix another shellcheck complain:

Rodrigo Vivi rodrigo.vivi at intel.com
Mon Aug 21 20:11:13 UTC 2017


^-- SC2053: Quote the rhs of != in [[ ]] to prevent glob matching.

Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 qf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qf b/qf
index 48dfe20b1693..cbe8a69e1a83 100755
--- a/qf
+++ b/qf
@@ -86,7 +86,7 @@ function repo_check # allow-detached
 
 	baseline=$(source patches/config ; echo $BASELINE)
 
-	if [[ $(git rev-parse HEAD) != $baseline ]] ; then
+	if [[ $(git rev-parse HEAD) != "$baseline" ]] ; then
 		echo Baseline commit doesn\'t match with quilt config
 		exit 7
 	fi
@@ -356,7 +356,7 @@ function qf_push
 	export_quilt_sha=$(git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2)
 	quilt_sha=$(cd patches ; git rev-parse $quilt_branch)
 
-	if [[ $export_quilt_sha != $quilt_sha ]] ; then
+	if [[ $export_quilt_sha != "$quilt_sha" ]] ; then
 		echo Quilt export is out of date, aborting
 		echo $export_quilt_sha
 		echo $quilt_sha
-- 
2.13.2



More information about the Intel-gfx mailing list