[Intel-gfx] [maintainer-tools PATCH 01/30] qf: Deprecate the use of qf without any subcommand.

[Daniel Vetter]

On Tue, Aug 22, 2017 at 08:55:33AM +0200, Daniel Vetter wrote:
> On Mon, Aug 21, 2017 at 01:10:51PM -0700, Rodrigo Vivi wrote:
> > These sequences here are already covered by `qf git` subcommand.
> > I double checked and confirmed that our continuously rebasing
> > bot does not use this qf directly here and I'm not aware
> > of anyone else using it. So let's remove it so we can start
> > handling everything with subcommands (dim style).
> 
> I do. It's super handy if you look around at the source code, but want to
> manipulate the qf history. This is similar to how git tools by default
> work anywhere in the working tree. It's not perfect (e.g. qf git blame
> doesn't do what you want it to do), but in many cases just adding a qf to
> whatever git command you though of Just Works (e.g. qf log).
> 
> If it annoys you too much I guess we could do qf run for cmds in general
> and qf git for git stuff, but would be really nice to keep this in some
> form.

Otoh my opinion doesn't matter all that much anymore, so if others think
it's ok I can live with qf git log :-)

Ack on the series, but I haven't really checked all the details, I think
Jani's the better person for that.
-Daniel

> -Daniel
> 
> > 
> > Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > Cc: Imre Deak <imre.deak at intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > ---
> >  qf     | 7 +------
> >  qf.rst | 7 -------
> >  2 files changed, 1 insertion(+), 13 deletions(-)
> > 
> > diff --git a/qf b/qf
> > index 1f056f90ef70..d1c331023230 100755
> > --- a/qf
> > +++ b/qf
> > @@ -480,12 +480,7 @@ case "$1" in
> >  		shift
> >  		gitk "$@"
> >  		;;
> > -	help)
> > -		qf_help
> > -		;;
> >  	*)
> > -		cd_toplevel
> > -		cd patches
> > -		git "$@"
> > +		qf_help
> >  		;;
> >  esac
> > diff --git a/qf.rst b/qf.rst
> > index 902b0d377f41..f0019d76c53d 100644
> > --- a/qf.rst
> > +++ b/qf.rst
> > @@ -233,13 +233,6 @@ help
> >  ----
> >  This help text here
> >  
> > -all other subcommands - IMPORTANT
> > ----------------------------------
> > -Any other subcommands are executed directly in the quilt patches
> > -directory as git commans. When using quilt flow in scripts it is
> > -import to use the explicit forwarding to avoid clashes with
> > -furture extensions.
> > -
> >  CONTRIBUTING
> >  ============
> >  
> > -- 
> > 2.13.2
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch