[Intel-gfx] [PATCH] drm/i915/cfl: Coffe Lake works on Kaby Lake PCH.

[Rodrigo Vivi]

On Mon, Aug 21, 2017 at 5:09 PM, Pandiyan, Dhinakaran
<dhinakaran.pandiyan at intel.com> wrote:
> On Mon, 2017-08-21 at 16:50 -0700, Rodrigo Vivi wrote:
>> Coffe Lake CPU on Kaby Lake PCH is possible.
>
> Typo ^

fixed when merging on dinq.

>
>> It does exist, and it does work.
>>
>> The only missed case was this warning here noticed
>> by Wendy who could get one system with this configuration
>> and reported the issue for us:
>>
>> Hardware Configuration
>> Board ID KBL S DDR4 UDIMM EV CRB
>> Processor    Intel® Processor code named Coffee Lake S, (6+2), 6 cores 12 threads, GT2, A0 (Internal) (QNJ4)
>>
>> [ 3.220585] WARNING: CPU: 10 PID: 206 at drivers/gpu/drm/i915/i915_drv.c:340 i915_driver_load+0x1210/0x1660 [i915]
>> [ 3.221312] Modules linked in: hid_generic usbhid i915 i2c_algo_bit drm_kms_helper e1000e syscopyarea sysfillrect sysimgblt nvme fb_sys_fops ptp ahci i2c_hid drm pps_core nvme_core libahci wmi hid video
>> [ 3.222050] CPU: 10 PID: 206 Comm: systemd-udevd Not tainted 4.13.0-rc5-intel-next+ #1
>> [ 3.222706] Hardware name: Intel Corporation Kabylake Client platform/KBL S DDR4 UDIMM EV CRB, BIOS KBLSE2R1.R00.X089.P00.1705051000 05/05/2017
>>
>> Cc: Wendy Wang <wendy.wang at intel.com>
>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>

thanks

>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 43100229613c..f10a078e3a55 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -239,7 +239,8 @@ static void intel_detect_pch(struct drm_i915_private *dev_priv)
>>                               dev_priv->pch_type = PCH_KBP;
>>                               DRM_DEBUG_KMS("Found Kaby Lake PCH (KBP)\n");
>>                               WARN_ON(!IS_SKYLAKE(dev_priv) &&
>> -                                     !IS_KABYLAKE(dev_priv));
>> +                                     !IS_KABYLAKE(dev_priv) &&
>> +                                     !IS_COFFEELAKE(dev_priv));
>>                       } else if (id == INTEL_PCH_CNP_DEVICE_ID_TYPE) {
>>                               dev_priv->pch_type = PCH_CNP;
>>                               DRM_DEBUG_KMS("Found Cannon Lake PCH (CNP)\n");
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br