[Intel-gfx] [PATCH 00/12] drm/i915: Fix up the CCS code

Daniel Vetter daniel at ffwll.ch
Fri Aug 25 17:17:01 UTC 2017


On Thu, Aug 24, 2017 at 10:10:48PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Looks like we ended up with a stale version of my CCS code in dinq.
> This series contains the remainder in smaller chunks. I also ended
> up adding a bunch of extra cleanup etc. on top.
> 
> The most important thing we need to get in is the change
> to the fb->offsets[] interpretation since that's ABI territory.
> The hash mode apparently doesn't require the nasty virtual address
> alignment tricks so that shouldn't have any ABI issues after all.
> 
> Entire series available here:
> git://github.com/vsyrjala/linux.git ccs_fixes
> 
> Cc: Ben Widawsky <ben at bwidawsk.net>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Cc: Daniel Stone <daniels at collabora.com>

Which of these do we need to cherry-pick over to -next-fixes? There's no
annotations about that. If the answer is "most" I'm leaning towards
disabling CCS for 4.14, minimal set would be ideal (and first in the patch
series).

Thanks, Daniel
> 
> Ville Syrjälä (12):
>   drm/i915: Treat fb->offsets[] as a raw byte offset instead of a linear
>     offset
>   drm/i915: Skip fence alignemnt check for the CCS plane
>   drm/i915: Switch over to the LLC/eLLC hotspot avoidance hash mode for
>     CCS
>   drm/i915: Add a comment exlaining CCS hsub/vsub
>   drm/i915: Nuke a pointless unreachable()
>   drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites
>   drm/i915: Clean up the sprite modifier checks
>   drm/i915: Add CCS capability for sprites
>   drm/i915: Allow up to 32KB stride on SKL+ "sprites"
>   drm: Fix modifiers_property kernel doc
>   drm: Check that the plane supports the request format+modifier combo
>   drm/i915: Remove the pipe/plane ID checks from
>     skl_check_ccs_aux_surface()
> 
>  drivers/gpu/drm/drm_atomic.c           |   8 +-
>  drivers/gpu/drm/drm_crtc.c             |   8 +-
>  drivers/gpu/drm/drm_crtc_internal.h    |   4 +-
>  drivers/gpu/drm/drm_plane.c            |  31 +++++--
>  drivers/gpu/drm/i915/i915_reg.h        |   8 +-
>  drivers/gpu/drm/i915/intel_display.c   | 145 +++++++++++++++++----------------
>  drivers/gpu/drm/i915/intel_drv.h       |   2 +
>  drivers/gpu/drm/i915/intel_engine_cs.c |  13 +++
>  drivers/gpu/drm/i915/intel_pm.c        |  27 +++---
>  drivers/gpu/drm/i915/intel_sprite.c    | 102 +++++++++++++++--------
>  include/drm/drm_mode_config.h          |   2 +-
>  11 files changed, 217 insertions(+), 133 deletions(-)
> 
> -- 
> 2.13.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list