[Intel-gfx] [PATCH] drm/i915: Set fake_vma.size as well as fake_vma.node.size for capture

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 1 00:20:41 UTC 2017


Quoting Chris Wilson (2017-12-01 00:15:36)
> When capturing the bo, we allocate an array for min(vma->size,
> vma->node.size) pages, plus a bit for compression overhead. Through my
> and CI testing, this was sufficient for the mostly empty NULL context as
> it compressed well (or the out-of-bounds access simply didn't cause an
> issue). However, in real workloads on Cannonlake, we were overflowing
> that array and causing havoc with the random memory corruption.
> 
> Reported-by: Rafael Antognolli <rafael.antognolli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103964
> Fixes: 4e90a6e22272 ("drm/i915: Record default HW state in the GPU error state")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Tested-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
Tested-by: Rafael Antognolli <rafael.antognolli at intel.com>
-Chris


More information about the Intel-gfx mailing list