[Intel-gfx] [PATCH i-g-t] igt: Make dependency on libunwind mandatory

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 1 14:37:29 UTC 2017


Quoting Arkadiusz Hiler (2017-12-01 13:19:54)
> With Android support gone there is not much reason for keeping libunwind
> dependency optional. This also deals (cheaply!) with ifdefs covering
> huge portions of code, removing a placement minefield.
> 
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> ---
>  configure.ac   | 12 ++----------
>  lib/igt_core.c | 13 ++++---------
>  meson.build    |  2 +-
>  3 files changed, 7 insertions(+), 20 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 84c6e646..6908f742 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -124,8 +124,10 @@ PKG_CHECK_MODULES(DRM, [libdrm >= 2.4.82])
>  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
>  PKG_CHECK_MODULES(KMOD, [libkmod])
>  PKG_CHECK_MODULES(PROCPS, [libprocps])
> +PKG_CHECK_MODULES(LIBUNWIND, [libunwind])
>  PKG_CHECK_MODULES(VALGRIND, [valgrind], [have_valgrind=yes], [have_valgrind=no])
>  
> +

Surplus '\n'.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list