[Intel-gfx] [PATCH 1/2] drm/i915: Implement WaDisableVFclkgate.

[Lucas De Marchi]

Hi,

On Fri, Dec 1, 2017 at 3:40 PM, Rafael Antognolli
<rafael.antognolli at intel.com> wrote:
> This workaround supposedly fixes some hangs in the VF unit.
>
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 3 +++
>  drivers/gpu/drm/i915/intel_pm.c | 5 +++++
>  2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 09bf043c1c2e..1358ce1513f6 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3875,6 +3875,9 @@ enum {
>  #define  SARBUNIT_CLKGATE_DIS          (1 << 5)
>  #define  RCCUNIT_CLKGATE_DIS           (1 << 7)
>
> +#define UNSLICE_UNIT_LEVEL_CLOCK       _MMIO(0x9434)

I think this should follow the other names
(UNSLICE_UNIT_LEVEL_CLKGATE). Otherwise it LGTM.

Lucas De Marchi

> +#define  VFUNIT_CLKGATE_DIS            (1 << 20)
> +
>  /*
>   * Display engine regs
>   */
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 67f326230a7e..87b9bdee48e5 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8446,6 +8446,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
>         if (IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0))
>                 val |= SARBUNIT_CLKGATE_DIS;
>         I915_WRITE(SLICE_UNIT_LEVEL_CLKGATE, val);
> +
> +       /* WaDisableVFclkgate:cnl */
> +       val = I915_READ(UNSLICE_UNIT_LEVEL_CLOCK);
> +       val |= VFUNIT_CLKGATE_DIS;
> +       I915_WRITE(UNSLICE_UNIT_LEVEL_CLOCK, val);
>  }
>
>  static void cfl_init_clock_gating(struct drm_i915_private *dev_priv)
> --
> 2.13.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi