[Intel-gfx] [PATCH 2/2] drm/i915: Implement WaDisableEarlyEOT.

Lucas De Marchi lucas.de.marchi at gmail.com
Mon Dec 4 20:54:44 UTC 2017


On Fri, Dec 1, 2017 at 3:40 PM, Rafael Antognolli
<rafael.antognolli at intel.com> wrote:
> There seems to be another clock gating issue which the workaround is
> described as:
>
>    "WA: Set 0xE4F0[1] = 1 to disable Early EOT of thread."
>
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

> ---
>  drivers/gpu/drm/i915/i915_reg.h        | 1 +
>  drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 1358ce1513f6..0f07f5900a6f 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -8145,6 +8145,7 @@ enum {
>  #define   PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE        (1<<8)
>  #define   STALL_DOP_GATING_DISABLE             (1<<5)
>  #define   THROTTLE_12_5                                (7<<2)
> +#define   DISABLE_EARLY_EOT                    (1<<1)
>
>  #define GEN7_ROW_CHICKEN2              _MMIO(0xe4f4)
>  #define GEN7_ROW_CHICKEN2_GT2          _MMIO(0xf4f4)
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 86d4c85c8725..bf581a0bb789 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1272,6 +1272,9 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)
>         if (ret)
>                 return ret;
>
> +       /* WaDisableEarlyEOT:cnl */
> +       WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN, DISABLE_EARLY_EOT);
> +
>         return 0;
>  }
>
> --
> 2.13.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi


More information about the Intel-gfx mailing list