[Intel-gfx] [PATCH] drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder

[Maarten Lankhorst]

Op 01-12-17 om 14:32 schreef Ville Syrjälä:
> On Thu, Nov 30, 2017 at 04:18:53PM +0100, Maarten Lankhorst wrote:
>> Normally this is called on a modeset, but the call is missing when
>> we inherit the mode from the BIOS, so make sure it's called somewhere
>> in hardware readout.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index cd60b4d5cd9d..26edae07e006 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -14843,6 +14843,8 @@ static void intel_sanitize_encoder(struct intel_encoder *encoder)
>>  
>>  		connector->base.dpms = DRM_MODE_DPMS_OFF;
>>  		connector->base.encoder = NULL;
>> +	} else if (connector) {
>> +		intel_opregion_notify_encoder(encoder, true);
>
> We should probably also do intel_opregion_notify_encoder(encoder, false)
> when intel_sanitize_encoder() disables the encoder.
Would it be terrible to always call intel_opregion_notify_encoder, with true or false depending on need?

~Maarten