[Intel-gfx] [PATCH v3 5/8] drm/i915/uc: Don't use -EIO to report missing firmware

Chris Wilson chris at chris-wilson.co.uk
Wed Dec 6 12:29:13 UTC 2017


Quoting Michal Wajdeczko (2017-12-05 16:38:41)
> -EIO has special meaning and is used when we want to allow
> engine initialization to fail and mark GPU as wedged.
> 
> However here at this function we should return error code
> that corresponds to upload status only, as any decision how
> to handle missing firmware should be done higher level function
> (silent fallback to non-GuC mode, fail into wedged mode, or
> abort driver load with fatal error).
> 
> v2: commit message update (Michal)
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>

With my fears expressed elsewhere,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list