[Intel-gfx] [PATCH] drm/i915: Drop fb reference on load_detect_pipe failure path

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 8 11:31:01 UTC 2017


Quoting Ville Syrjälä (2017-12-08 11:14:17)
> On Thu, Dec 07, 2017 at 10:00:25PM +0000, Chris Wilson wrote:
> > When intel_modeset_setup_plane_state() fails drop the local framebuffer
> > reference before jumping to the error, otherwise we leak the framebuffer.
> 
> Or we could just
> https://patchwork.freedesktop.org/patch/165486/

Why not both! :)
 
> This is
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> nonetheless.

Ta, less controversial patch for more, grand improvement for you :)
-Chris


More information about the Intel-gfx mailing list