[Intel-gfx] [PATCH] drm/i915: Print an error message for a reset failure on gen2

Chris Wilson chris at chris-wilson.co.uk
Tue Dec 12 11:11:50 UTC 2017


Quoting Ville Syrjälä (2017-12-12 06:35:31)
> On Mon, Dec 11, 2017 at 08:40:40PM +0000, Chris Wilson wrote:
> > Since on gen2, we do not universally have a GPU reset implementation, we
> > fail i915_reset() at intel_has_gpu_reset(). However, this is also
> > intentionally disabled for CI testing and so it only has a debug
> > message. Promote that debug message to a user-facing error message that
> > should explain why their machine became unusable following the GPU hang.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Thanks for the suggestion and reviewing. Having a second guess isn't
pretty, I considered making intel_has_gpu_reset return a bitmask of
reasons or something like that, but for now this is a simple fix for the
issue of gen2 failing reset without a warning.

Applied,
-Chris


More information about the Intel-gfx mailing list