[Intel-gfx] [PATCH 3/3] drm/i915/selftests: Fix up igt_reset_engine

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 18 21:54:42 UTC 2017


Quoting Michel Thierry (2017-12-18 21:50:17)
> On 17/12/17 05:28, Chris Wilson wrote:
> > Now that we skip a per-engine reset on an idle engine, we need to update
> > the selftest to take that into account. In the process, we find that we
> > were not stressing the per-engine reset very hard, so add those missing
> > active resets.
> > 
> > v2: Actually test i915_reset_engine() by loading it with requests.
> > 
> > Fixes: f6ba181ada55 ("drm/i915: Skip an engine reset if it recovered before our preparations")
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> 
> 
> Reviewed-by: Michel Thierry <michel.thierry at intel.com>

I could have put more effort into making it one function with a couple
of parameters (idle/active engine-reset; idle/active other engines), but
honestly I was just happy to put something together that worked!
 
> And all these subtests passed with and without GuC in SKL.

Happy and sad, I was hoping to break something! :)

Thanks, pushed for a quieter CI.
-Chris


More information about the Intel-gfx mailing list