[Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Fix ring ignore
Chris Wilson
chris at chris-wilson.co.uk
Tue Dec 19 09:15:21 UTC 2017
Quoting Tvrtko Ursulin (2017-12-19 08:46:52)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Breakage from previous refactoring.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Reported-by: John Harrison <John.C.Harrison at intel.com>
> Cc: John Harrison <John.C.Harrison at intel.com>
> ---
> scripts/trace.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 588126ad46ab..98e4a9843a43 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -383,7 +383,7 @@ while (<>) {
> $tp{$kv[0]} = $kv[1];
> }
>
> - return undef if exists $tp{'ring'} and exists $ignore_ring{$tp{'ring'}};
> + next if exists $tp{'ring'} and exists $ignore_ring{$tp{'ring'}};
Skip if this tracepoint has a ring field (didn't you say you wanted to
change those to engines ;) and that name is included in the set of
ignores. Move on to the next tracepoint.
Does perl not like an undefined key? next if $ignore_ring{$tp{'ring'}};
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris
More information about the Intel-gfx
mailing list