[Intel-gfx] [PATCH i-g-t v5] overlay: parse tracepoints from sysfs to figure out fields' location

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Dec 19 15:27:56 UTC 2017


On 19/12/17 15:15, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2017-12-19 14:26:11)
>> With changes going to drm-tip, the tracepoints field locations are
>> going to change. This change introduces a tracepoint parser (using a
>> peg parser) which lets us figure out field positions on the fly.
>>
>> v2: Fix automake build (Lionel)
>>
>> v3: Make overlay build conditional on peg (Petri)
>>      Make wait_end callback more readable (Chris)
>>      Drop tracepoint_id(), instead parsing from format file (Lionel)
>>
>> v4: Fix existing configure.ac issue with overlay build (Petri)
>>
>> v5: Silence unused function (Lionel)
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>>
>> For the build system changes:
>> Acked-by: Petri Latvala <petri.latvala at intel.com>
> If it works, it works.
> Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
>
> One of the next steps would be failing if the tracepoint doesn't contain
> the desired data.
> -Chris
>
It will fail if the parsing fails. Now if someone removes a field from 
the kernel, yeah, we're a bit screwed...



More information about the Intel-gfx mailing list