[Intel-gfx] [PATCH] drm/i915: Remove pointer indirection for hangcheck_state local

[Rodrigo Vivi]

On Tue, Dec 19, 2017 at 01:09:48PM +0000, Chris Wilson wrote:
> Use the local on-stack struct directly rather than hide it behind a
> pointer. This should be both clearer for the reader and the compiler (we
> rely on the compiler seeing through the functions to spot uninitialized
> uses of the local).

much better!

> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hangcheck.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hangcheck.c b/drivers/gpu/drm/i915/intel_hangcheck.c
> index 0acd9dd3ed5c..fe99439aaf39 100644
> --- a/drivers/gpu/drm/i915/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/intel_hangcheck.c
> @@ -429,18 +429,18 @@ static void i915_hangcheck_elapsed(struct work_struct *work)
>  	intel_uncore_arm_unclaimed_mmio_detection(dev_priv);
>  
>  	for_each_engine(engine, dev_priv, id) {
> -		struct intel_engine_hangcheck cur_state, *hc = &cur_state;
> +		struct intel_engine_hangcheck hc;

I wonder if we couldn't move these definition up...

anyways:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

>  		const bool busy = intel_engine_has_waiter(engine);
>  
>  		semaphore_clear_deadlocks(dev_priv);
>  
> -		hangcheck_load_sample(engine, hc);
> -		hangcheck_accumulate_sample(engine, hc);
> -		hangcheck_store_sample(engine, hc);
> +		hangcheck_load_sample(engine, &hc);
> +		hangcheck_accumulate_sample(engine, &hc);
> +		hangcheck_store_sample(engine, &hc);
>  
>  		if (engine->hangcheck.stalled) {
>  			hung |= intel_engine_flag(engine);
> -			if (hc->action != ENGINE_DEAD)
> +			if (hc.action != ENGINE_DEAD)
>  				stuck |= intel_engine_flag(engine);
>  		}
>  
> -- 
> 2.15.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx