[Intel-gfx] [PATCH 6/8] drm/i915: Update intel_device_info_runtime_init() parameter

Chris Wilson chris at chris-wilson.co.uk
Wed Dec 20 19:11:53 UTC 2017


Quoting Michal Wajdeczko (2017-12-20 18:36:08)
> As we try to follow object-verb pattern in our functions, update
> intel_device_info_runtime_init() parameter from dev_priv to info.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

The patch looks like churn, but on closer inspection it does make sense
from a consistency pov.

> ---
>  drivers/gpu/drm/i915/i915_drv.c          |  2 +-
>  drivers/gpu/drm/i915/intel_device_info.c | 10 +++++++---
>  drivers/gpu/drm/i915/intel_device_info.h |  2 +-
>  3 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 6f14986..06eea8d 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1088,7 +1088,7 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv)
>         if (i915_inject_load_failure())
>                 return -ENODEV;
>  
> -       intel_device_info_runtime_init(dev_priv);
> +       intel_device_info_runtime_init(mkwrite_device_info(dev_priv));

Just too bad this is so ugly!

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list