[Intel-gfx] [PATCH] drm/i915/psr: Fix register name mess up.

Pandiyan, Dhinakaran dhinakaran.pandiyan at intel.com
Wed Dec 20 19:40:45 UTC 2017




On Wed, 2017-12-20 at 09:24 +0000, Chris Wilson wrote:
> Quoting Dhinakaran Pandiyan (2017-12-20 04:35:20)
> > Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for
> > hsw_psr_disable()") swapped status and control registers while fixing
> > indentation. The _ctl at the end of the status register name must have to
> > led to this.
> 
> My bad. https://www.mrc-cbu.cam.ac.uk/people/matt.davis/cmabridge/

Yeah, took me several rounds of checking to ensure I changed it
correctly.

> So what does STATUS_CTL control? That seems to be a bad name, does bspec
> really call it that?

So I looked it up, it doesn't. I'll send a patch soon.
-DK

> 
> References: https://www.mrc-cbu.cam.ac.uk/people/matt.davis/cmabridge/
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris


More information about the Intel-gfx mailing list