[Intel-gfx] [PATCH i-g-t 1/1] igt_aux: Skip hibernation attempts if hibernation is not configured

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 21 12:59:41 UTC 2017


Quoting Petri Latvala (2017-12-21 12:53:41)
> rtcwake doesn't give us meaningful ways of differentiating different
> reasons for hibernation failing. CI doesn't configure hibernation to
> work at this time, and hibernation attempts will always fail. Check
> for the configuration in the form of resume= appearing on the kernel
> command line, which is what swsusp uses to find the resume device to
> hibernate to.

resume= is not required for hibernation.
 
> Hibernation failures have dug up a couple of bugs in the past, but
> finding actual bugs in the swamp of "rtcwake failed with 1" results is
> difficult enough to overweigh that benefit.

The ones in CI are genuine though, does it not appear? At the start of
the hibernate it picks swapspace to store the image, but at the end of
the sequence, it can not read back from the swapspace it chose.
-Chris


More information about the Intel-gfx mailing list