[Intel-gfx] [PATCH v2 06/38] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 1 11:43:13 UTC 2017


On Wed, Feb 01, 2017 at 11:27:00AM +0000, Tvrtko Ursulin wrote:
> 
> On 19/01/2017 11:41, Chris Wilson wrote:
> >Third retroactive test, make sure that the seqno waiters are woken.
> 
> No changelog and you haven't added any of the comments I've asked
> for. I really think it is time to add more documentation in the
> tests. I don't feel like reverse engineering what this test does in
> the future (like I had to when initially reviewing it).

No. I commented on your reply which I felt was sufficient for the
simplicity of the test.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list