[Intel-gfx] [PATCH] drm/i915: Remove i915_execbuffer_params

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Feb 3 12:45:23 UTC 2017


On pe, 2017-02-03 at 10:46 +0000, Chris Wilson wrote:
> On Fri, Feb 03, 2017 at 10:33:44AM +0000, Tvrtko Ursulin wrote:
> > 
> > > > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > 
> > Tidy i915_gem_do_execbuffer by removing the structure which
> > is under no plans to be used any longer.
> > 
> > This improves the redability of the code, decreases lines
> > of source and shrinks the binary.
> 
> If you put them alongside the params we pass along, it is even better.
> 
> https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=33dc0f3f6d065cf76abd9ad9778c182519fb49a8
> 
> is what I've been trying to get in for the year or so.

Well, the remaining bits could be moved like that, yep.

But I'd do it as a second patch on top of this, for easier review.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list